-
Notifications
You must be signed in to change notification settings - Fork 18.5k
runtime: avoid zeroing scavenged memory #76063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR (HEAD: 5b2d4a4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/715160. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Lance Yang: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from t hepudds: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-27T05:29:16Z","revision":"9a51fbcf842017a87bfcb3b8eec08caa7f2b3b42"} Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from t hepudds: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/x_debug-gotip-linux-amd64 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
This PR (HEAD: 6cde005) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/715160. Important tips:
|
|
Message from Lance Yang: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Jorropo: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-27T09:29:54Z","revision":"2174f04568be29dc18b4eff3b779f14bb0579f69"} Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Jorropo: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64_avx512-greenteagc has failed with summary (view all results):
To reproduce, try Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
This PR (HEAD: 38d7ab8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/715160. Important tips:
|
|
Message from Jorropo: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-27T11:12:21Z","revision":"d2d4f8243afaf5940be99dd69749fcc7629706a8"} Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Jorropo: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64_avx512-greenteagc has failed with summary (view all results):
To reproduce, try Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
This PR (HEAD: 526ce3d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/715160. Important tips:
|
|
Message from Lance Yang: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from t hepudds: Patch Set 4: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-27T12:00:40Z","revision":"fb86fc61e95b33671f4770d49d85f23c1d51bcc5"} Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from t hepudds: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
This PR (HEAD: 438c095) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/715160. Important tips:
|
|
Message from t hepudds: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-27T16:27:27Z","revision":"6fb2b26354d1f304d427f0464fccc2b9a5181919"} Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from t hepudds: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 5: This CL has failed the run. Reason: Tryjob golang/try/x_debug-gotip-linux-amd64 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
This PR (HEAD: fefae7f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/715160. Important tips:
|
|
This PR (HEAD: 46fae8d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/715160. Important tips:
|
|
This PR (HEAD: 439a33e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/715160. Important tips:
|
|
Message from Lance Yang: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
On Linux, memory returned to the kernel via MADV_DONTNEED is guaranteed to be zero-filled on its next use. This commit leverages this kernel behavior to avoid a redundant software zeroing pass in the runtime, improving performance. Signed-off-by: Lance Yang <[email protected]>
|
This PR (HEAD: 6c8df32) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/715160. Important tips:
|
|
Message from Lance Yang: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from t hepudds: Patch Set 9: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 9: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-28T09:33:31Z","revision":"fbff89c8ffbd0b4747e1f68b1007f496f458c413"} Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from t hepudds: Patch Set 9: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 9: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Go LUCI: Patch Set 9: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Lance Yang: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Michael Knyszek: Patch Set 9: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from Michael Knyszek: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
|
Message from David Chase: Patch Set 9: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/715160. |
On Linux, memory returned to the kernel via MADV_DONTNEED is guaranteed to be zero-filled on its next use. This commit leverages this kernel behavior to avoid a redundant software zeroing pass in the runtime, improving performance. Change-Id: Ia14343b447a2cec7af87644fe8050e23e983c787 GitHub-Last-Rev: 6c8df32 GitHub-Pull-Request: #76063 Reviewed-on: https://go-review.googlesource.com/c/go/+/715160 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Reviewed-by: David Chase <[email protected]>
|
This PR is being closed because golang.org/cl/715160 has been merged. |
On Linux, memory returned to the kernel via MADV_DONTNEED is guaranteed
to be zero-filled on its next use.
This commit leverages this kernel behavior to avoid a redundant software
zeroing pass in the runtime, improving performance.